Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove logbook #10119

Merged
merged 2 commits into from
May 13, 2024
Merged

remove logbook #10119

merged 2 commits into from
May 13, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented May 9, 2024

resolves #8027

Problem

We don't use logbook anymore.

Solution

Remove it and all references to it.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 90.56604% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 88.60%. Comparing base (84cc540) to head (4ecef69).
Report is 4 commits behind head on main.

Files Patch % Lines
core/dbt/task/runnable.py 72.72% 3 Missing ⚠️
core/dbt/contracts/sql.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10119      +/-   ##
==========================================
+ Coverage   88.23%   88.60%   +0.36%     
==========================================
  Files         181      180       -1     
  Lines       22787    22403     -384     
==========================================
- Hits        20107    19851     -256     
+ Misses       2680     2552     -128     
Flag Coverage Δ
integration 85.89% <90.56%> (+0.31%) ⬆️
unit 62.86% <16.98%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label May 13, 2024
@emmyoop
Copy link
Member Author

emmyoop commented May 13, 2024

The only thing that was modified in the artifacts dir was a comment so added the artifact_minor_upgrade label.

@emmyoop emmyoop marked this pull request as ready for review May 13, 2024 13:12
@emmyoop emmyoop requested a review from a team as a code owner May 13, 2024 13:12
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice to see this finally happen!

@emmyoop emmyoop merged commit 03b621f into main May 13, 2024
69 of 70 checks passed
@emmyoop emmyoop deleted the er/pull-out-logger-again branch May 13, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2786] Remove "legacy logger"
3 participants