Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8 backport] Unit test selection method (#10102) #10109

Merged
merged 1 commit into from
May 8, 2024

Conversation

MichelleArk
Copy link
Contributor

(cherry picked from commit 43d6c2f)

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

(cherry picked from commit 43d6c2f)
@cla-bot cla-bot bot added the cla:yes label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.21%. Comparing base (8926c2c) to head (a7e567b).

Files Patch % Lines
core/dbt/graph/selector_methods.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           1.8.latest   #10109      +/-   ##
==============================================
+ Coverage       87.23%   88.21%   +0.97%     
==============================================
  Files             181      181              
  Lines           22733    22750      +17     
==============================================
+ Hits            19832    20069     +237     
+ Misses           2901     2681     -220     
Flag Coverage Δ
integration 85.55% <17.64%> (+1.04%) ⬆️
unit 62.62% <88.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk marked this pull request as ready for review May 8, 2024 17:51
@MichelleArk MichelleArk requested a review from a team as a code owner May 8, 2024 17:51
@MichelleArk MichelleArk changed the title Unit test selection method (#10102) [1.8 backport] Unit test selection method (#10102) May 8, 2024
@MichelleArk MichelleArk merged commit 85f461b into 1.8.latest May 8, 2024
122 checks passed
@MichelleArk MichelleArk deleted the backport-10102-to-1.8.latest branch May 8, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants