-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add primary_key
to manifest
#10096
Add primary_key
to manifest
#10096
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10096 +/- ##
==========================================
- Coverage 88.23% 88.20% -0.04%
==========================================
Files 181 181
Lines 22787 22805 +18
==========================================
+ Hits 20107 20115 +8
- Misses 2680 2690 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked offline with Dave, supportive of singular primary_key
if that makes more sense in the data context!
|
resolves #9824
Problem
This PR writes out the output of
ModelNode.infer_primary_keys()
to the manifest as a top levelprimary_key
object.Checklist