Better error message for Private package definition #10084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10084 +/- ##
==========================================
- Coverage 88.21% 88.18% -0.04%
==========================================
Files 181 181
Lines 22748 22759 +11
==========================================
+ Hits 20068 20069 +1
- Misses 2680 2690 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ChenyuLInx
commented
May 3, 2024
| @@ -304,7 +305,7 @@ def test__invalid_color_config_block( | |||
| self, | |||
| project, | |||
| ): | |||
| with pytest.raises(ValidationError): | |||
| with pytest.raises((ValidationError, ConfigUpdateError)): | |||
There was a problem hiding this comment.
This caused an issue in CI because of the execution order of tests. Since Gerda also ran into this before, I am just fixing it here.
ChenyuLInx
force-pushed
the
cl/package_error
branch
from
349e03a to
4dc17f2
Compare
MichelleArk
reviewed
May 6, 2024
core/dbt/deps/resolver.py
Outdated
| @@ -74,6 +75,10 @@ def update_from(self, src: List[PackageSpec]) -> None: | |||
| pkg = TarballUnpinnedPackage.from_contract(contract) | |||
| elif isinstance(contract, GitPackage): | |||
| pkg = GitUnpinnedPackage.from_contract(contract) | |||
| elif isinstance(contract, PrivatePackage): | |||
| raise DbtInternalError( | |||
There was a problem hiding this comment.
I don't think this should be a DbtInternalError if it can be caused by user-configuration and is resolvable given user action
MichelleArk
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10083
Problem
We are introducing better support for private package in dbt-cloud, which allows people to define a new package.
If we don't do anything in core, this would lead to core raising
Instead, we should have a clear message telling people to define git package.
Solution
Checklist