Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize more of the repository's unit tests #10060

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

QMalcolm
Copy link
Contributor

@QMalcolm QMalcolm commented Apr 27, 2024

Addresses: #9961

Problem

Unit tests test specific functions or classes. As such it really makes sense for unit tests to live in files that mirror the file paths of the source code being tested.

Solution

This PR moves

  • test_retry.py
  • test_manager.py
  • test_option_types.py
  • test_manifest.py
  • test_macro_resolver.py

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (f6b2cb7) to head (e30eeb7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10060      +/-   ##
==========================================
- Coverage   88.20%   88.14%   -0.06%     
==========================================
  Files         181      181              
  Lines       22665    22665              
==========================================
- Hits        19991    19978      -13     
- Misses       2674     2687      +13     
Flag Coverage Δ
integration 85.44% <ø> (-0.13%) ⬇️
unit 62.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QMalcolm QMalcolm force-pushed the qmalcolm--reorganize-more-unit-tests branch from f63be08 to e30eeb7 Compare April 27, 2024 14:24
@QMalcolm QMalcolm marked this pull request as ready for review April 27, 2024 15:05
@QMalcolm QMalcolm requested a review from a team as a code owner April 27, 2024 15:05
@QMalcolm QMalcolm merged commit 35062ca into main Apr 29, 2024
62 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--reorganize-more-unit-tests branch April 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants