Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate materialization overrides from imported packages (#9971) #10008

Merged
merged 3 commits into from
May 1, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Apr 22, 2024

Same changes as 1.7 backport: #9998

Backport of #9956 to 1.6

Solution

The easiest way to explain & review this PR is commit-by-commit:

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

No breaking interface changes. However, a deprecation warning will now be emitted for projects with flags defined in profiles.yml instead of dbt_project.yml. This PR introduces the capability to define flags in dbt_project.yml so I don't see an issue there.

@MichelleArk MichelleArk marked this pull request as ready for review April 30, 2024 23:12
@MichelleArk MichelleArk requested a review from a team as a code owner April 30, 2024 23:12
@MichelleArk
Copy link
Contributor Author

Confirmed same 🎩 scenarios work as expected as tested for the related 1.7 backport (#9998 (comment))

  • dbt run passes as usual
  • dbt run when profiles.yml specifies config (but emits deprecation warning)
  • dbt run when dbt_project.yml specifies flags + respects their configurations as expected
  • custom materialization from root project works as expected
  • added a 'default' materialization override for view in an installed package -> saw deprecation warning
  • ^ + setting require_explicit_package_overrides_for_builtin_materializations: true -> no deprecation warning and confirmed materialization override not reached
  • require_explicit_package_overrides_for_builtin_materializations: false` -> deprecation warning, materialization override occurred

@MichelleArk MichelleArk requested a review from graciegoheen May 1, 2024 14:12
@MichelleArk MichelleArk merged commit 3c82a02 into 1.6.latest May 1, 2024
98 checks passed
@MichelleArk MichelleArk deleted the backport-9971-to-1.6.latest branch May 1, 2024 15:24
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants