Apply suggestions from code review

dbt-labs · Sep 26, 2023 · c6d4875 · c6d4875
1 parent d258156
commit c6d4875
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.changes/unreleased/Features-20230926-134728.yaml b/.changes/unreleased/Features-20230926-134728.yaml
@@ -1,5 +1,5 @@
 kind: Features
-body: Raise a wanring when a contracted model has a numeric field without scale defined
+body: Raise a warning when a contracted model has a numeric field without scale defined
 time: 2023-09-26T13:47:28.645383-05:00
 custom:
   Author: emmyoop

diff --git a/core/dbt/include/global_project/macros/adapters/columns.sql b/core/dbt/include/global_project/macros/adapters/columns.sql
@@ -49,7 +49,6 @@
       {%- if col['data_type'] is not defined -%}
         {%- do col_err.append(col['name']) -%}
       {#-- If this column's type is just 'numeric' then it is missing precision/scale, raise a warning --#}
-      {#- elif api.Column.create(col['name'], col['data_type'].strip()).is_numeric() -#}
       {%- elif col['data_type'].strip().lower() in ('numeric', 'decimal', 'number') -%}
         {%- do col_naked_numeric.append(col['name']) -%}
       {%- endif -%}