Skip to content

Commit

Permalink
Add TODO comment
Browse files Browse the repository at this point in the history
  • Loading branch information
jtcohen6 committed Mar 18, 2022
1 parent e045b09 commit b220819
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions core/dbt/parser/generic_test_builders.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,10 @@ def __init__(
self.fqn_name: str = ""

if "name" in self.args:
# TODO: Should we append the model name to the test name here?
# Or trust the user to have globally unique names within their project?
# Logic like this, with accounting for source table targets:
# generic_test_name = f"{self.args["name"]}_{target.name}"
self.compiled_name = self.args["name"]
self.fqn_name = self.args["name"]
del self.args["name"]
Expand Down

0 comments on commit b220819

Please sign in to comment.