Skip to content

Commit

Permalink
feedback based on mike review
Browse files Browse the repository at this point in the history
  • Loading branch information
McKnight-42 committed Jun 5, 2024
1 parent 9efa169 commit 8c2ad87
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions core/dbt/parser/generic_test_builders.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,7 @@ def __init__(

# Process config args if present
if "config" in self.args:
self.config.update(self._process_config_args(self.args["config"]))
del self.args["config"]
self.config.update(self._render_values(self.args.pop("config", {})))

if self.namespace is not None:
self.package_name = self.namespace
Expand Down Expand Up @@ -165,16 +164,7 @@ def _process_legacy_args(self):
raise SameKeyNestedError()
if not value and "config" in self.args:
value = self.args["config"].pop(key, None)
if value is not None:
config[key] = value

return self._render_values(config)

def _process_config_args(self, config_dict: Dict[str, Any]) -> Dict[str, Any]:
config = {}
for key, value in config_dict.items():
if value is not None:
config[key] = value
config[key] = value

return self._render_values(config)

Expand Down

0 comments on commit 8c2ad87

Please sign in to comment.