Skip to content

Commit

Permalink
[Backport 1.3.latest] Fix #9907: Add retry to tox to reduce flaky tes…
Browse files Browse the repository at this point in the history
…ts due to network failures (#10180)
  • Loading branch information
aranke authored May 21, 2024
1 parent 4b6b1a6 commit 78901d6
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 5 deletions.
16 changes: 12 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,12 @@ jobs:
python -m pip install tox
tox --version
- name: Run tox
run: tox
- name: Run unit tests
uses: nick-fields/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: tox -e unit

- name: Get current date
if: always()
Expand Down Expand Up @@ -169,8 +173,12 @@ jobs:
python -m pip install tox
tox --version
- name: Run tests
run: tox -- --ddtrace
- name: Run integration tests
uses: nick-fields/retry@v3
with:
timeout_minutes: 30
max_attempts: 3
command: tox -- --ddtrace

- name: Get current date
if: always()
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/structured-logging-schema-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ jobs:
# integration tests generate a ton of logs in different files. the next step will find them all.
# we actually care if these pass, because the normal test run doesn't usually include many json log outputs
- name: Run integration tests
run: tox -e integration -- -nauto
uses: nick-fields/retry@v3
with:
timeout_minutes: 30
max_attempts: 3
command: tox -e integration -- -nauto

# apply our schema tests to every log event from the previous step
# skips any output that isn't valid json
Expand Down

0 comments on commit 78901d6

Please sign in to comment.