Skip to content

Commit

Permalink
Update parameter names in _get_export_config to be more verbose
Browse files Browse the repository at this point in the history
  • Loading branch information
QMalcolm committed Nov 13, 2023
1 parent dd3be16 commit 5ec2363
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/dbt/parser/schema_yaml_readers.py
Original file line number Diff line number Diff line change
Expand Up @@ -670,11 +670,11 @@ def _generate_saved_query_config(
return config

def _get_export_config(
self, unparsed: Dict[str, Any], saved_query_config: SavedQueryConfig
self, unparsed_export_config: Dict[str, Any], saved_query_config: SavedQueryConfig
) -> ExportConfig:
# Combine the two dictionaries using dictionary unpacking
# the second dictionary is the one whose keys take priority
combined = {**saved_query_config.__dict__, **unparsed}
combined = {**saved_query_config.__dict__, **unparsed_export_config}

Check warning on line 677 in core/dbt/parser/schema_yaml_readers.py

View check run for this annotation

Codecov / codecov/patch

core/dbt/parser/schema_yaml_readers.py#L677

Added line #L677 was not covered by tests
# `schema` is the user facing attribute, but for DSI protocol purposes we track it as `schema_name`
if combined.get("schema") is not None and combined.get("schema_name") is None:
combined["schema_name"] = combined["schema"]

Check warning on line 680 in core/dbt/parser/schema_yaml_readers.py

View check run for this annotation

Codecov / codecov/patch

core/dbt/parser/schema_yaml_readers.py#L679-L680

Added lines #L679 - L680 were not covered by tests
Expand Down

0 comments on commit 5ec2363

Please sign in to comment.