Skip to content

Commit

Permalink
Update comment about input_measures setting in metric parsing (#9118)
Browse files Browse the repository at this point in the history
In [#7984](#7984)
we began setting a metrics `type_params.input_measures` during metric
processing post parsing. However in that PR we didn't clean up the comment
in the parser about setting `input_measures`. This is that post fact
cleanup.
  • Loading branch information
QMalcolm authored Nov 17, 2023
1 parent 19f027b commit 4d02ef6
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions core/dbt/parser/schema_yaml_readers.py
Original file line number Diff line number Diff line change
Expand Up @@ -308,9 +308,7 @@ def _get_metric_type_params(self, type_params: UnparsedMetricTypeParams) -> Metr
window=self._get_time_window(type_params.window),
grain_to_date=grain_to_date,
metrics=self._get_metric_inputs(type_params.metrics),
# TODO This is a compiled list of measure/numerator/denominator as
# well as the `input_measures` of included metrics. We're planning
# on doing this as part of CT-2707
# input measures are calculated via metric processing post parsing
# input_measures=?,
)

Expand Down

0 comments on commit 4d02ef6

Please sign in to comment.