Stream instead of buffer JSON in read_json/write_json #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 55.77% 55.51% -0.26%
==========================================
Files 50 50
Lines 3050 3064 +14
==========================================
Hits 1701 1701
- Misses 1349 1363 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ChenyuLInx
approved these changes
Mar 14, 2024
| with open(path, "w", encoding="utf-8") as f: | ||
| json.dump(data, f, cls=dbt_common.utils.encoding.JSONEncoder) | ||
| except Exception as exc: | ||
| # See write_file() for an explanation of this error handling. |
There was a problem hiding this comment.
Thanks for the helpful comment!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://dbtlabs.atlassian.net/browse/MNTL-179
Description
There is no reason to keep JSON in memory as an intermediate step during read/write, and it was contributing to max resident set size, so stream it instead.
Checklist
changie newto create a changelog entry