Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break core on purpose to test merges #67

Closed
wants to merge 2 commits into from
Closed

Break core on purpose to test merges #67

wants to merge 2 commits into from

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Feb 6, 2024

Testing for #54

Description

This is to test that merging will be blocked when core functional tests fail.

Checklist

Copy link

github-actions bot commented Feb 6, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50555ee) 51.47% compared to head (6148b50) 51.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   51.47%   51.49%   +0.02%     
==========================================
  Files          49       49              
  Lines        2856     2851       -5     
==========================================
- Hits         1470     1468       -2     
+ Misses       1386     1383       -3     
Flag Coverage Δ
unit 51.49% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop mentioned this pull request Feb 6, 2024
5 tasks
@emmyoop emmyoop closed this in #68 Feb 6, 2024
@emmyoop emmyoop reopened this Feb 6, 2024
@emmyoop emmyoop added the Skip Core Testing Skip running core tests on merge. This should only be used when core&common have dependent changes. label Feb 6, 2024
@emmyoop emmyoop closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Core Testing Skip running core tests on merge. This should only be used when core&common have dependent changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants