add changelog check workflow #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage ? 51.07%
=======================================
Files ? 47
Lines ? 2798
Branches ? 0
=======================================
Hits ? 1429
Misses ? 1369
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aranke
approved these changes
Jan 31, 2024
| @@ -91,7 +92,7 @@ description = "Env for running development commands for testing" | |||
| features = ["test"] | |||
|
|
|||
| [tool.hatch.envs.test.scripts] | |||
| unit = "- python -m pytest {args:tests/unit}" | |||
| unit = "python -m pytest --cov=dbt_common --cov-report=xml {args:tests/unit}" | |||
There was a problem hiding this comment.
Is this part of a different change?
There was a problem hiding this comment.
It is. The original got clobbered by a conflict resolution. I can pull it out into its own PR if you'd prefer.
There was a problem hiding this comment.
No worries, just checking.
Since it's 1 line, I think it's fine to keep here and merge.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves none
Description
Adds an automated changelog check to ensure we add changelogs for relevant changes.
Checklist
changie newto create a changelog entry