Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python 3.8 #212

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Deprecate Python 3.8 #212

merged 3 commits into from
Oct 21, 2024

Conversation

peterallenwebb
Copy link
Contributor

Description

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner October 21, 2024 17:07
@cla-bot cla-bot bot added the cla:yes label Oct 21, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (1bad6b7) to head (821aa90).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   68.48%   68.48%           
=======================================
  Files          52       52           
  Lines        3389     3389           
=======================================
  Hits         2321     2321           
  Misses       1068     1068           
Flag Coverage Δ
unit 68.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓
Looks good - just a comment around the changelog wording.

@@ -0,0 +1,6 @@
kind: Under the Hood
body: Remove support and testing for Python 3.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By updating the pyproject.toml, won't it also prevent you from installing with python 3.8? So really we're fully dropping support for python 3.8, not just in testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the best call. We've dropped it in dbt-core and dbt-adapters already, so I can't see much reason to retain it here.

@peterallenwebb peterallenwebb added this pull request to the merge queue Oct 21, 2024
@peterallenwebb peterallenwebb removed this pull request from the merge queue due to a manual request Oct 21, 2024
@peterallenwebb peterallenwebb added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 65d7ba5 Oct 21, 2024
19 checks passed
@peterallenwebb peterallenwebb deleted the deprecate_python_3_8 branch October 21, 2024 19:44
@emmyoop emmyoop mentioned this pull request Nov 5, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants