-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Python 3.8 #212
Deprecate Python 3.8 #212
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 68.48% 68.48%
=======================================
Files 52 52
Lines 3389 3389
=======================================
Hits 2321 2321
Misses 1068 1068
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪓
Looks good - just a comment around the changelog wording.
@@ -0,0 +1,6 @@ | |||
kind: Under the Hood | |||
body: Remove support and testing for Python 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By updating the pyproject.toml, won't it also prevent you from installing with python 3.8? So really we're fully dropping support for python 3.8, not just in testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the best call. We've dropped it in dbt-core and dbt-adapters already, so I can't see much reason to retain it here.
Description
Checklist
changie new
to create a changelog entry