Implement hatch #21
Implement hatch #21
Conversation
.flake8
Outdated
There was a problem hiding this comment.
These settings now live in pyproject.toml
Makefile
Outdated
There was a problem hiding this comment.
hatch replaces this functionality. instead of make unit you now run hatch run unit-tests, etc
emmyoop
force-pushed
the
er/build-tooling
branch
from
caed6c5 to
0cbbf70
Compare
|
Also opened dbt-labs/dbt-core#9452 as i was looking at linting. |
|
|
||
| - name: Install Hatch | ||
| - name: Install pre-commit |
There was a problem hiding this comment.
Why would we install pre-commit in CI? I'm probably answering my own question, but is it to catch the eof and trailing whitespace issues?
There was a problem hiding this comment.
You are indeed answering your own question.
|
|
||
| ### Running `dbt-common` | ||
|
|
||
| This repository is just a template and cannot be run. | ||
| This repository cannot be run on its own. |
There was a problem hiding this comment.
I'm not sure that this is entirely true. I think it just has very specific use cases that make it less valuable outside of the dbt ecosystem. I'm arguing semantics, but I think the distinction we're looking for is that between a library and an application. dbt-core was more of an application whereas this is a library. I'm only pointing it out because this may convey a different sentiment than intended. After all, one of the goals of breaking up the monorepo was to establish stand-alone packages, albeit very use-case-specific packages.
resolves #41
resolves #17
Description
Now that we're using hatch:
Checklist
changie newto create a changelog entry