Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move test_semver to common #136

Merged
merged 1 commit into from
May 21, 2024
Merged

move test_semver to common #136

merged 1 commit into from
May 21, 2024

Conversation

ChenyuLInx
Copy link
Contributor

related to #dbt-labs/dbt-core#9961

Description

Checklist

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner May 21, 2024 04:59
@cla-bot cla-bot bot added the cla:yes label May 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.57%. Comparing base (4c96366) to head (6fcd2cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   56.37%   64.57%   +8.19%     
==========================================
  Files          50       50              
  Lines        3088     3088              
==========================================
+ Hits         1741     1994     +253     
+ Misses       1347     1094     -253     
Flag Coverage Δ
unit 64.57% <ø> (+8.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this moved over!

@ChenyuLInx ChenyuLInx added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 0c120ab May 21, 2024
17 checks passed
@ChenyuLInx ChenyuLInx deleted the cl/move_test_semver branch May 21, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants