Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove final underscore #110

Merged
merged 3 commits into from
Apr 23, 2024
Merged

remove final underscore #110

merged 3 commits into from
Apr 23, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 19, 2024

resolves #109

Description

Remove the final underscore from the env vars. The existing testing already tested this behavior in tests/unit/test_invocation_context.py.

Checklist

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.26%. Comparing base (7ee58a8) to head (ab23838).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   56.26%   56.26%           
=======================================
  Files          50       50           
  Lines        3082     3082           
=======================================
  Hits         1734     1734           
  Misses       1348     1348           
Flag Coverage Δ
unit 56.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as ready for review April 23, 2024 13:05
@emmyoop emmyoop requested a review from a team as a code owner April 23, 2024 13:05
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@emmyoop emmyoop added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 87a7cc5 Apr 23, 2024
17 checks passed
@emmyoop emmyoop deleted the er/logs branch April 23, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not require the final underscore in secret constants
3 participants