Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error_tag util to the ui module #108

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

QMalcolm
Copy link
Contributor

resolves #107

Description

In dbt-labs/dbt-core#9886 we found that we needed an error_tag function. Because it didn't exist in dbt-common, we added it to core temporarily as a stop gap. This PR gets it added to dbt-common so core can remove the stop gap.

Checklist

@QMalcolm QMalcolm requested a review from a team as a code owner April 12, 2024 18:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.79%. Comparing base (05c24e4) to head (4e336d0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   55.60%   55.79%   +0.19%     
==========================================
  Files          50       50              
  Lines        3070     3072       +2     
==========================================
+ Hits         1707     1714       +7     
+ Misses       1363     1358       -5     
Flag Coverage Δ
unit 55.79% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@QMalcolm QMalcolm added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit b76d0e6 Apr 12, 2024
17 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--107-add-error-tag-helper branch April 12, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error_tag helper to ui.py
3 participants