Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the PR checklist items related to the type of change #243

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Dec 13, 2024

resolves #241

Problem

Our PR template is pretty long, which makes it onerous to use. It is also unnecessarily different from the PR templates of dbt-core, dbt-adapters, etc.

Solution

We already use GitHub labels like bug, enhancement, and documentation on issues to indicate the type of change. Since we require associated issues for each PR, we can use those labels and remove the related checklist items from the PR template. This will make things quite a bit shorter and easier to read PR descriptions 😎

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • [N/A] I have verified that these changes work locally
  • [N/A] I have updated the README.md (if applicable)
  • [N/A] I have added tests & descriptions to my models (and macros if applicable)

@dbeatty10 dbeatty10 marked this pull request as ready for review December 13, 2024 20:40
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 13, 2024
@dbeatty10 dbeatty10 merged commit af4e2c0 into main Dec 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the PR checklist items related to the type of change
1 participant