Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "I have added an entry to CHANGELOG.md" from the PR template #239

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Dec 13, 2024

resolves #238

This is a:

  • under the hood change

Problem

We have a checklist item reminding contributors to manually update the changelog. But we have been using the "Generate release notes" button in GitHub in place of manual changelog entries. So any changelog entries that are merged are just overwritten during the release.

Also, we have a long checklist, which lowers its utility.

Solution

  • Remove "I have added an entry to CHANGELOG.md" from the PR template
  • Checklist is one item shorter

Checklist

@dbeatty10 dbeatty10 marked this pull request as ready for review December 13, 2024 18:51
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 13, 2024
@dbeatty10 dbeatty10 merged commit 6137ca6 into main Dec 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "I have added an entry to CHANGELOG.md" from the PR template
1 participant