Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin setuptools to address setuptools#4483 #1284

Closed
wants to merge 3 commits into from
Closed

Pin setuptools to address setuptools#4483 #1284

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89a2fea
pin setuptools to address setuptools#4483
mikealfare Jul 18, 2024
60fb9dc
changelog
mikealfare Jul 18, 2024
75bfabf
fix changelog
mikealfare Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20240718-093755.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Pin `setuptools` to address pypa/setuptools#4483ls
time: 2024-07-18T09:37:55.774924-04:00
custom:
Author: mikealfare
Issue: "1284"
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ jobs:
- name: Install python dependencies
run: |
python -m pip install --user --upgrade pip
python -m pip install --upgrade wheel setuptools twine check-wheel-contents
python -m pip --version
python -m pip install -r build-requirements.txt

- uses: actions/download-artifact@v3
with:
name: dist
Expand Down
5 changes: 5 additions & 0 deletions build-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
bumpversion~=0.6.0
check-wheel-contents~=0.6.0
setuptools~=70.0
twine~=5.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were installing this directly and upgrading, so we never actually used 4.0. 4.0 is also broken, see pypa/twine#977. From the post in there, the date of the fix, and the dates of the releases, the fix was released as part of 5.0.

wheel~=0.42
5 changes: 2 additions & 3 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter
# if version 1.x or greater -> pin to major version
# if version 0.x -> pin to minor
black>=24.3
bumpversion~=0.6.0
click~=8.1
ddtrace==2.3.0
flake8~=7.0
Expand All @@ -29,5 +28,5 @@ tox~=4.11
types-pytz~=2023.3
types-protobuf~=4.24
types-requests~=2.31
twine~=4.0
wheel~=0.42

-r build-requirements.txt
Loading