Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support agate Integer type, test with empty seed #1004

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Support agate Integer type, test with empty seed #1004

merged 2 commits into from
Nov 7, 2023

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 7, 2023

resolves #1003

Problem

dbt Core introduced an agate Integer type. This provides code to support it and a test for a bug constructing an empty seed.

Solution

Add a "convert_integer_type" method to dbt/adapters/bigquery/impl.py

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner November 7, 2023 15:13
@gshank gshank requested a review from McKnight-42 November 7, 2023 15:13
@cla-bot cla-bot bot added the cla:yes label Nov 7, 2023
@gshank gshank merged commit 548d532 into main Nov 7, 2023
13 checks passed
@gshank gshank deleted the adap-1003-agate_integer_type branch November 7, 2023 19:11
github-actions bot pushed a commit that referenced this pull request Nov 7, 2023
@gshank @github-actions
Support agate Integer type, test with empty seed (#1004)
69ae19d 
(cherry picked from commit 548d532)
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Merged
mikealfare pushed a commit that referenced this pull request Nov 7, 2023
@github-actions @gshank
Support agate Integer type, test with empty seed (#1004) (#1005)
05b221f 
(cherry picked from commit 548d532)

Co-authored-by: Gerda Shank <[email protected]>
github-actions bot pushed a commit that referenced this pull request Nov 8, 2023
@gshank @github-actions
Support agate Integer type, test with empty seed (#1004)
6c71f7c 
(cherry picked from commit 548d532)
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Merged
mikealfare pushed a commit that referenced this pull request Nov 8, 2023
@github-actions @gshank
Support agate Integer type, test with empty seed (#1004) (#1012)
fd75cf9 
(cherry picked from commit 548d532)

Co-authored-by: Gerda Shank <[email protected]>
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Apr 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42 McKnight-42 is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-1010] Support for new agate data type in BigQuery
3 participants
@gshank @colin-rogers-dbt @mikealfare