-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADAP-1126: Filter pull request checks to only impacted packages #606
Open
mikealfare
wants to merge
2
commits into
main
Choose a base branch
from
monorepo/affected-packages-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikealfare
changed the title
Filter pull request checks to only impacted packages
ADAP-1126: Filter pull request checks to only impacted packages
Jan 14, 2025
mikealfare
had a problem deploying
to
dbt-bigquery
January 14, 2025 21:00 — with
GitHub Actions
Error
mikealfare
had a problem deploying
to
dbt-bigquery
January 14, 2025 21:00 — with
GitHub Actions
Error
mikealfare
had a problem deploying
to
dbt-bigquery
January 14, 2025 21:00 — with
GitHub Actions
Error
mikealfare
had a problem deploying
to
dbt-bigquery
January 14, 2025 21:00 — with
GitHub Actions
Error
mikealfare
temporarily deployed
to
dbt-bigquery
January 14, 2025 21:08 — with
GitHub Actions
Inactive
mikealfare
temporarily deployed
to
dbt-bigquery
January 14, 2025 21:08 — with
GitHub Actions
Inactive
mikealfare
temporarily deployed
to
dbt-bigquery
January 14, 2025 21:08 — with
GitHub Actions
Inactive
mikealfare
temporarily deployed
to
dbt-bigquery
January 14, 2025 21:08 — with
GitHub Actions
Inactive
mikealfare
had a problem deploying
to
dbt-spark
January 14, 2025 21:08 — with
GitHub Actions
Failure
mikealfare
had a problem deploying
to
dbt-spark
January 14, 2025 21:08 — with
GitHub Actions
Failure
mikealfare
had a problem deploying
to
dbt-spark
January 14, 2025 21:08 — with
GitHub Actions
Failure
mikealfare
had a problem deploying
to
dbt-spark
January 14, 2025 21:08 — with
GitHub Actions
Failure
mikealfare
had a problem deploying
to
dbt-spark
January 14, 2025 21:08 — with
GitHub Actions
Failure
mikealfare
had a problem deploying
to
dbt-spark
January 14, 2025 21:08 — with
GitHub Actions
Failure
mikealfare
had a problem deploying
to
dbt-spark
January 14, 2025 21:08 — with
GitHub Actions
Failure
mikealfare
had a problem deploying
to
dbt-spark
January 14, 2025 21:08 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that we have all of the adapters in the same repo, CI checks have grown in number. We should limit CI checks to only those that apply to affected packages. We can also use this as an opportunity to test changes to dependent packages, e.g. a change to
dbt-adapters
should trigger tests across all adapters.Solution
dorny/path-filters
action that has been previously used to filter down to affected packages.dbt-tests-adapter
has no unit tests nor integration tests, but does need a changelog