Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dbt-adapters to include unit test feature updates #43

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

port unit testing adapters changes from dbt-labs/dbt-core#8411

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@MichelleArk
Copy link
Contributor

Looks good regarding the macro changes! Something small I noticed was that adapterse/base/relation.py was also updated by dbt-labs/dbt-core#8411 and those changes don't seem to be reflected on this branch: relation.py changes on unit testing branch

I don't entirely recall why/if this change was strictly necessary. I don't see any usage of the method in dbt-core so I suspect it was just a bit of clean-up to reflect the optionality of limit -- but @gshank may have a better recollection (source commit of relation.py changes)

@mikealfare
Copy link
Contributor

@colin-rogers-dbt Are there any associated tests that also need to move over? Should I look into that as part of the testing migration?

@colin-rogers-dbt
Copy link
Contributor Author

Are there any associated tests that also need to move over? Should I look into that as part of the testing migration?

@mikealfare I'm guessing so, I think that will happen naturally as part of the PR to delete dbt-adapter-tests from core/when you break out dbt-postgres

@mikealfare
Copy link
Contributor

Are there any associated tests that also need to move over? Should I look into that as part of the testing migration?

@mikealfare I'm guessing so, I think that will happen naturally as part of the PR to delete dbt-adapter-tests from core/when you break out dbt-postgres

Sounds good. I added an item to our migration list to make sure we don't lose it. So consider the testing half of this feature as out of scope for this PR.

Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like all of the functional code changes from the linked PR.

@colin-rogers-dbt colin-rogers-dbt merged commit dc11843 into main Jan 23, 2024
5 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the updateGlobalProjectForUnitTests branch January 23, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants