ADAP-1167: Add table format telemetry reporting to Athena adapter #403
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @VanTudor |
| @@ -60,6 +60,10 @@ | |||
| seeds__expected_target_post = "id,status\n" + "\n".join([f"{i},{i}" for i in range(PARALLELISM)]) | |||
|
|
|||
|
|
|||
| @pytest.mark.flaky | |||
| @pytest.mark.skip( | |||
| reason="Unreliable test in practice. No apparent reliable way to trigger a retry, which causes the test to fail. Disabled until we get a resolution here https://github.com/dbt-labs/dbt-athena/pull/657/files#r1922043351" | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This test seems to fail randomly, irrespective of my changes. E.g. https://github.com/dbt-labs/dbt-athena/actions/runs/12756721311/job/35555467442#step:6:595
| uses: ./.github/workflows/_integration-tests.yml | ||
| strategy: | ||
| fail-fast: false | ||
| max-parallel: 1 |
There was a problem hiding this comment.
I did these workflow changes so that TestIcebergRetriesDisabled is isolated in a separate job and so that it's forced to run in series. This is to rule out that parallel test runs write to the same place, causing the test to fail.
However, I ended up disabling that test (see comment below). I think it's debatable whether to still keep the workflow changes here (as scaffolding). I'm leaning towards yes, but happy to remove this stuff, in case you disagree.
Description
Send out table format telemetry data in the Athena Adapter
Checklist