Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test prompt in PR template. #391

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Dec 19, 2024

Problem

We don't have a solid process around testing adapter changes in this repo. This can lead to partial testing, which gives a false sense of security as to the safety of a code change.

Solution

Let's formalize that by encouraging folks to include CI runs in every request opened.

Each adapter has an integration test action. This action can specify pull request names directly so that anyone can easily test their code in concrete repos. This will be even easier once we are in mono repo.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Dec 19, 2024
@VersusFacit VersusFacit requested a review from a team as a code owner December 19, 2024 01:44
@cla-bot cla-bot bot added the cla:yes label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant