Append model.batch.id
to suffix in make_temp_relation
when present
#361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #360
Problem
Batches for a microbatch model were all getting the same temp relation name. This is fine if batches are running sequentially. However, we're enabling concurrent batch execution support. In which case, if the batches have the same temp relation name, they may clobber each other and result in "bad things"™️
Solution
Append the
model.batch.id
to the suffix of the temporary relation name when presentChecklist