Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protobuf to >=5.0,<6.0 #346

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Upgrade protobuf to >=5.0,<6.0 #346

merged 6 commits into from
Nov 19, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 12, 2024

See dbt-common dbt-labs/dbt-common#218, dbt-core dbt-labs/dbt-core#10658

Problem

Difficulties installing and coordinating older versions of protobuf.

Solution

Update protobuf to >=5.0,<6.0

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner November 12, 2024 14:45
@cla-bot cla-bot bot added the cla:yes label Nov 12, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@gshank gshank changed the title Upgrade protobuf to >=5.0,<=6.0 Upgrade protobuf to >=5.0,<6.0 Nov 12, 2024
@gshank gshank merged commit a8a89f4 into main Nov 19, 2024
10 checks passed
@gshank gshank deleted the upgrade_protobuf branch November 19, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants