Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render to and to_columns on column and model level fk constraints #260

Merged
merged 11 commits into from
Jul 25, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jul 5, 2024

resolves #271
docs dbt-labs/docs.getdbt.com/# - part of dbt-core issue

Core PR: dbt-labs/dbt-core#10414

Problem

As part of dbt-labs/dbt-core#8062. we are parsing and compiling new to and to_columns fields on ModelLevelConstraint and ColumnLevelConstraint.

Solution

dbt-adapters uses these new fields, when populated, to render out the foreign key constraint instead of expression. expression support remains as-is for backward-compatability.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
Copy link

github-actions bot commented Jul 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk force-pushed the render-foreign-constraint-ref branch 2 times, most recently from 424bcda to c86f483 Compare July 6, 2024 15:42
@MichelleArk MichelleArk force-pushed the render-foreign-constraint-ref branch from c86f483 to 7ae4b00 Compare July 6, 2024 17:56
@MichelleArk MichelleArk requested a review from mikealfare July 23, 2024 15:02
gshank
gshank previously approved these changes Jul 23, 2024
@MichelleArk MichelleArk requested a review from mikealfare July 23, 2024 19:20
@MichelleArk MichelleArk merged commit fbfa095 into main Jul 25, 2024
15 checks passed
@MichelleArk MichelleArk deleted the render-foreign-constraint-ref branch July 25, 2024 14:56
@MichelleArk MichelleArk mentioned this pull request Jul 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Constraints] Render 'to' and 'to_columns' fields on foreign key constraints
3 participants