-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render to and to_columns on column and model level fk constraints #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
MichelleArk
force-pushed
the
render-foreign-constraint-ref
branch
2 times, most recently
from
July 6, 2024 15:42
424bcda
to
c86f483
Compare
MichelleArk
force-pushed
the
render-foreign-constraint-ref
branch
from
July 6, 2024 17:56
c86f483
to
7ae4b00
Compare
5 tasks
5 tasks
MichelleArk
commented
Jul 23, 2024
MichelleArk
commented
Jul 23, 2024
mikealfare
reviewed
Jul 23, 2024
gshank
previously approved these changes
Jul 23, 2024
mikealfare
reviewed
Jul 25, 2024
mikealfare
reviewed
Jul 25, 2024
mikealfare
approved these changes
Jul 25, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #271
docs dbt-labs/docs.getdbt.com/# - part of dbt-core issue
Core PR: dbt-labs/dbt-core#10414
Problem
As part of dbt-labs/dbt-core#8062. we are parsing and compiling new to and to_columns fields on ModelLevelConstraint and ColumnLevelConstraint.
Solution
dbt-adapters uses these new fields, when populated, to render out the foreign key constraint instead of expression. expression support remains as-is for backward-compatability.
Checklist