-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update replace.sql #186
base: main
Are you sure you want to change the base?
Update replace.sql #186
Conversation
{% set is_replaceable = existing_relation.type == target_relation_type and existing_relation.can_be_replaced %} maybe {% set is_replaceable = existing_relation.type == target_relation.type and existing_relation.can_be_replaced %}
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @rongfengliang |
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @rongfengliang! We'll need to test this against concrete adapters to make sure that the functionality we're effectively turning on here works. In the meantime, if you could update the changelog body, then this will be ready to merge pending those tests.
@mikealfare functional tests performed on:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including reference to concrete testing of this
resolves: #187
maybe