Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a control in that verifies that dbt-core functionality is not being used within an adapter #177

Merged
merged 23 commits into from
Apr 19, 2024
Merged

Add a control in that verifies that dbt-core functionality is not being used within an adapter #177

merged 23 commits into from
Apr 19, 2024

Conversation

mikealfare
Copy link
Contributor

resolves #144

Problem

We are naming dbt-core as a dependency for convenience, but don't actually want to use it's functionality in order to stay de-coupled. We need a way to enforce this approach.

Solution

  • add a script that checks for dbt-core usage
  • add a hatch post-install script that uninstalls dbt-core in the development environments
  • add a CI check that uses at least one of these methods to verify in CI

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 17, 2024
@github-actions GitHub Actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare marked this pull request as draft April 17, 2024 23:30
@mikealfare mikealfare changed the base branch from main to config/add-precommit April 18, 2024 13:49
mikealfare added 17 commits April 18, 2024 09:50
@mikealfare
Merge branch 'refs/heads/config/add-precommit' into constrain-dbt-cor…
b3f5927 
…e-deps

# Conflicts:
#	.pre-commit-config.yaml
@mikealfare
update formatting to be four space tab
9ba039b
@mikealfare
make dbt-core-check a hook that can be reused
265942c
@mikealfare
make dbt-core-check a hook that can be reused
d49e1df
@mikealfare
make dbt-core-check a reusable pre-commit hook
4d22b78
@mikealfare
make dbt-core-check a reusable pre-commit hook
ed8c3c5
@mikealfare
make dbt-core-check a reusable pre-commit hook
63ee9b8
@mikealfare
make dbt-core-check a reusable pre-commit hook
0c62428
@mikealfare
reference the new dbt-core-check hook
6bcbcc6
@mikealfare
reference the new dbt-core-check hook
c72696b
@mikealfare
reference dbt-labs/pre-commit-hooks
eed4a66
@mikealfare
update hook reference
94ce90c
@mikealfare
update the default hatch virtual environments directory to .hatch
c2c4d8f
@mikealfare
move linting reqs into pre-commit-config
2bcac13
@mikealfare
move linting reqs into pre-commit-config
b7c374f
@mikealfare
upgrade linters
877dd2e
@mikealfare
ignore type errors
8dd0022
@mikealfare mikealfare marked this pull request as ready for review April 19, 2024 01:27
@mikealfare mikealfare merged commit 581a6c0 into config/add-precommit Apr 19, 2024
11 checks passed
@mikealfare mikealfare deleted the constrain-dbt-core-deps branch April 19, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikealfare mikealfare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Linting/pre-commit check on dbt-core as a dependency
1 participant
@mikealfare