Skip to content

Commit

Permalink
remove workflow dispatch testing for changelog-entry-check since it i…
Browse files Browse the repository at this point in the history
…s not possible
  • Loading branch information
mikealfare committed Dec 7, 2024
1 parent 3dfa158 commit a3bf5b8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 13 deletions.
13 changes: 2 additions & 11 deletions .github/workflows/_changelog-entry-check.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: "Changelog entry check"

# this cannot be tested via workflow_dispatch
# dorny/paths-filter inspects the current trigger to determine how to compare branches
on:
pull_request:
workflow_call:
inputs:
package:
Expand All @@ -12,16 +13,6 @@ on:
description: "The PR number"
type: string
required: true
workflow_dispatch:
inputs:
package:
description: "Choose the package to test"
type: string
default: "dbt-adapters"
pull-request:
description: "The PR number"
type: string
required: true

permissions:
contents: read
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ dependencies = [
setup = "pre-commit install"
code-quality = "pre-commit run --all-files"
unit-tests = "python -m pytest {args:tests/unit}"

test-changelog-entry-check = "gh workflow run _changelog-entry-check.yml --ref $(git rev-parse --abbrev-ref HEAD) -f package=dbt-adapters -f pull-request={args}"
test-publish = "gh workflow run publish.yml --ref $(git rev-parse --abbrev-ref HEAD) -f package=dbt-adapters -f branch=$(git rev-parse --abbrev-ref HEAD) -f deploy-to=test -f pypi-internal=false -f pypi-public=true"

[tool.hatch.envs.build]
Expand Down

0 comments on commit a3bf5b8

Please sign in to comment.