fix: revert to golang 1.20 to fix issue with args casting

dbschenker · Oct 3, 2024 · 8853493 · 8853493
1 parent 00399d7
commit 8853493
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 57 deletions.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -2,7 +2,7 @@ variables:
   TYPE: app
   MULTI_ARCH: "true"
 
-image: golang:1.21
+image: golang:1.20
 
 include:
   - project: shared-scripts/gitlab-ci

diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM --platform=$BUILDPLATFORM golang:1.21-alpine as builder
+FROM --platform=$BUILDPLATFORM golang:1.20-alpine as builder
 
 ARG RELEASE_VERSION=development
 

diff --git a/charts/thundering-herd-scheduler/README.md b/charts/thundering-herd-scheduler/README.md
@@ -6,35 +6,35 @@ A Helm chart for Thundering herd scheduler
 
 ## Values
 
-| Key | Type | Default | Description |
-|-----|------|---------|-------------|
-| affinity | object | `{}` | Afinity for pods |
-| fullnameOverride | string | `""` | Full name override |
-| image | object | `{"pullPolicy":"IfNotPresent","repository":"ghcr.io/dbschenker/thundering-herd-scheduler","tag":"v1.21-0"}` | Thundering-herd-scheduler container image settings |
-| image.pullPolicy | string | `"IfNotPresent"` | Image pull policy |
-| image.repository | string | `"ghcr.io/dbschenker/thundering-herd-scheduler"` | Registry address |
-| image.tag | string | `"v1.21-0"` | Image tag. Overrides the image tag whose default is the chart appVersion. |
-| imagePullSecrets | list | `[]` | Map with names of image pull secrets |
-| nameOverride | string | `""` | Name override |
-| nodeSelector | object | `{}` | Node selector |
-| podAnnotations | object | `{"prometheus.io/port":"10251","prometheus.io/scheme":"http","prometheus.io/scrape":"true"}` | Pod annotations |
-| podDisruptionBudget.enabled | bool | `true` | Controls if PodDisruptionBadget object is created |
-| podDisruptionBudget.minAvailable | int | `1` | Pod disruption budget - minAvailable. Enforces that at least one pod is available. |
-| podSecurityContext | object | `{}` | Pod securoty context |
-| replicaCount | int | `3` | Thundering-herd-scheduler replica count. By default it is set to 3. |
-| resources | object | `{"limits":{"cpu":"250m","memory":"768Mi"},"requests":{"cpu":"100m","memory":"300Mi"}}` | Resource limit and request settings |
-| scheduler.burst | int | `60` | burst rate limiter setting |
-| scheduler.logLevel | int | `1` | Thundering-herd-scheduler logging level |
-| scheduler.pluginConfig.maxRetries | int | `5` | How many times a pod can run through the process before it anyway get's scheduled |
-| scheduler.pluginConfig.parallelStartingPodsPerNode | int | `3` | How many pods should get scheduled in parallel before pods are moved into waiting state |
-| scheduler.pluginConfig.timeoutSeconds | int | `5` | Based on how many times the pod was attempted to be scheduled using the scheduler, a wait is implemented with the following rule timeoutSeconds^2 * retries |
-| scheduler.qps | int | `30` | qps rate limiter setting |
+| Key | Type | Default                                                                                                                   | Description |
+|-----|------|---------------------------------------------------------------------------------------------------------------------------|-------------|
+| affinity | object | `{}`                                                                                                                      | Afinity for pods |
+| fullnameOverride | string | `""`                                                                                                                      | Full name override |
+| image | object | `{"pullPolicy":"IfNotPresent","repository":"ghcr.io/dbschenker/thundering-herd-scheduler","tag":"v1.29-0"}`               | Thundering-herd-scheduler container image settings |
+| image.pullPolicy | string | `"IfNotPresent"`                                                                                                          | Image pull policy |
+| image.repository | string | `"ghcr.io/dbschenker/thundering-herd-scheduler"`                                                                          | Registry address |
+| image.tag | string | `"v1.29-0"`                                                                                                               | Image tag. Overrides the image tag whose default is the chart appVersion. |
+| imagePullSecrets | list | `[]`                                                                                                                      | Map with names of image pull secrets |
+| nameOverride | string | `""`                                                                                                                      | Name override |
+| nodeSelector | object | `{}`                                                                                                                      | Node selector |
+| podAnnotations | object | `{"prometheus.io/port":"10251","prometheus.io/scheme":"http","prometheus.io/scrape":"true"}`                              | Pod annotations |
+| podDisruptionBudget.enabled | bool | `true`                                                                                                                    | Controls if PodDisruptionBadget object is created |
+| podDisruptionBudget.minAvailable | int | `1`                                                                                                                       | Pod disruption budget - minAvailable. Enforces that at least one pod is available. |
+| podSecurityContext | object | `{}`                                                                                                                      | Pod securoty context |
+| replicaCount | int | `3`                                                                                                                       | Thundering-herd-scheduler replica count. By default it is set to 3. |
+| resources | object | `{"limits":{"cpu":"250m","memory":"768Mi"},"requests":{"cpu":"100m","memory":"300Mi"}}`                                   | Resource limit and request settings |
+| scheduler.burst | int | `60`                                                                                                                      | burst rate limiter setting |
+| scheduler.logLevel | int | `1`                                                                                                                       | Thundering-herd-scheduler logging level |
+| scheduler.pluginConfig.maxRetries | int | `5`                                                                                                                       | How many times a pod can run through the process before it anyway get's scheduled |
+| scheduler.pluginConfig.parallelStartingPodsPerNode | int | `3`                                                                                                                       | How many pods should get scheduled in parallel before pods are moved into waiting state |
+| scheduler.pluginConfig.timeoutSeconds | int | `5`                                                                                                                       | Based on how many times the pod was attempted to be scheduled using the scheduler, a wait is implemented with the following rule timeoutSeconds^2 * retries |
+| scheduler.qps | int | `30`                                                                                                                      | qps rate limiter setting |
 | securityContext | object | `{"capabilities":{"drop":["ALL"]},"privileged":false,"readOnlyRootFilesystem":true,"runAsNonRoot":true,"runAsUser":1000}` | Security context settings |
-| serviceAccount.annotations | object | `{}` | Annotations to add to the service account |
-| serviceAccount.create | bool | `true` | Specifies whether a service account should be created |
-| serviceAccount.name | string | `""` | The name of the service account to use. If not set and create is true, a name is generated using the fullname template |
-| tolerations | list | `[]` | Tolerations |
-| topologySpreadConstraints | object | `{}` | Pod's topology spread constraint settings. |
+| serviceAccount.annotations | object | `{}`                                                                                                                      | Annotations to add to the service account |
+| serviceAccount.create | bool | `true`                                                                                                                    | Specifies whether a service account should be created |
+| serviceAccount.name | string | `""`                                                                                                                      | The name of the service account to use. If not set and create is true, a name is generated using the fullname template |
+| tolerations | list | `[]`                                                                                                                      | Tolerations |
+| topologySpreadConstraints | object | `{}`                                                                                                                      | Pod's topology spread constraint settings. |
 
 ----------------------------------------------
 Autogenerated from chart metadata using [helm-docs v1.8.1](https://github.com/norwoodj/helm-docs/releases/v1.8.1)
diff --git a/download-deps.sh b/download-deps.sh
@@ -3,7 +3,7 @@
 VERSION=${1#"v"}
 if [ -z "$VERSION" ]; then
   echo "Please specify the Kubernetes version: e.g."
-  echo "./download-deps.sh v1.21.0"
+  echo "./download-deps.sh v1.29.0"
   exit 1
 fi
 

diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/dbschenker/thundering-herd-scheduler
 
-go 1.21
+go 1.20
 
 require (
 	github.com/benbjohnson/clock v1.3.5