-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A brown cursor shows up better #7
base: master
Are you sure you want to change the base?
Conversation
Not all Emacs implementations seem to agree on the color of "brown." In particular, the brown listed at http://en.wikipedia.org/wiki/X11_color_names looks distinctly red in the context of a zenburn background.
bump |
Thanks for working on this. I’m reluctant to change the cursor color for a few reasons. First of all, I think the simple inverted cursor is perfect, so I don’t want to change that on Linux and Windows, and I want to have that on OS X too as soon as the bug is fixed preventing you from changing the foreground color of the cursor. Second of all, the current color works really well when you’re using a bar cursor instead of a block one, whereas a colored bar looks weird and is hard to see. I also don’t really like the brown color per se, although obviously you’re right it’s a lot more practical on OS X with the non-blinking block cursor. I’ve been playing around with a few different colors for that, and #406080 looks pretty decent to me under most text faces. (We don’t use much blue in zenburn, so blue works pretty well to make something stand out.) Do you think that’s too hard to see? Also, have you tried turning on Blink Cursor mode and/or switching to a bar cursor? (Even a hollow block cursor works in theory, though it looks strange.) I’m not sure what is best, but I’m not totally against special-casing OS X and making the cursor have color there. I almost feel like we should be trying to get the actual Emacs bug fixed instead of trying to work around it, though. |
on Sun Aug 28 2011, dbrock <reply+i-1307544-0027961efa681208c7b578d69fe83549faf2c9b1-AT-reply.github.com> wrote:
I'm now using Mitsuharu's MacOS emacs port, where I don't notice a bug, I found the inverted color to be a little bit jarring and contrast-y at
Understood. Of course, I use a block ;-)
Yeah, too hard. I like the original settings better.
Sorry, but yuck. Those don't work for me.
If there is one, yeah we should. Dave Abrahams |
This works; you just need (for some reason) to try it from a fresh Emacs session.
Fixes #6