Fix: Update url in the downloader and tests #91
Conversation
| private const DOWNLOAD_ENDPOINT_JSON = 'https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing'; | ||
| private const DOWNLOAD_ENDPOINT_JSON = 'https://storage.googleapis.com/chrome-for-testing-public'; |
There was a problem hiding this comment.
Did the download URL change for previous versions as well, or are those still on edgedl.me.gvt1.com?
We'd want the download for all versions to still work, not just the latest version.
I like your suggestion in #90:
But possibly we should look into the option to resolve the download url, from the page we use to resolve the versions?
There was a problem hiding this comment.
The endpoint just returns a 404 now, as it seems to have been taken down completely.
I'll quickly have a look to see if i can find an endpoint from an older version, and see if that returns a 404 as well.
But https://googlechromelabs.github.io/chrome-for-testing/ just mentions the new URL now. For stable, beta, dev and canary
There was a problem hiding this comment.
Oof. It seems only the new ones have actually moved. Which means we will need to add an additional check, with a third endpoint :/
There was a problem hiding this comment.
The switch has been made when going from version 121.0.6166 to 121.0.6167 (looking at https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build-with-downloads.json)
Do you agree with adding an additional check with the specific patch version included? @dbrekelmans
There was a problem hiding this comment.
I'll merge this as a patch version. Would be nice to get a follow-up PR if you're willing to resolve the URL in the same way as the versions.
Fixes #90