Fix: skip if below or equal test cases.

Signed-off-by: dblock <[email protected]>
dblock · Aug 20, 2024 · b2f5616 · b2f5616
1 parent ea08582
commit b2f5616
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 13 deletions.
diff --git a/internal/test/helper.go b/internal/test/helper.go
@@ -100,12 +100,12 @@ func GetVersion(client *opensearchapi.Client) (int64, int64, int64, error) {
 	return opensearch.ParseVersion(resp.Version.Number)
 }
 
-// SkipIfBelowVersion skips a test if the cluster version is below a given version
-func SkipIfBelowVersion(t *testing.T, client *opensearchapi.Client, majorVersion, patchVersion int64, testName string) {
+// SkipIfBelowOrEqualVersion skips a test if the cluster version is below or equal a given version
+func SkipIfBelowOrEqualVersion(t *testing.T, client *opensearchapi.Client, majorVersion, patchVersion int64, testName string) {
 	t.Helper()
 	major, patch, _, err := GetVersion(client)
 	assert.Nil(t, err)
-	if major <= majorVersion && patch <= patchVersion {
+	if major < majorVersion || (major == majorVersion && patch <= patchVersion) {
 		t.Skipf("Skiping %s as version %d.%d.x does not support this endpoint", testName, major, patch)
 	}
 }

diff --git a/opensearchapi/api_cat_test.go b/opensearchapi/api_cat_test.go
@@ -366,7 +366,7 @@ func TestCatClient(t *testing.T) {
 	for catType, value := range testCases {
 		t.Run(catType, func(t *testing.T) {
 			if catType == "ClusterManager" {
-				ostest.SkipIfBelowVersion(t, client, 1, 3, catType)
+				ostest.SkipIfBelowOrEqualVersion(t, client, 1, 3, catType)
 			}
 			for _, testCase := range value {
 				t.Run(testCase.Name, func(t *testing.T) {
@@ -399,7 +399,7 @@ func TestCatClient(t *testing.T) {
 			ostest.CompareRawJSONwithParsedJSON(t, resp.Allocations, resp.Inspect().Response)
 		})
 		t.Run("ClusterManager", func(t *testing.T) {
-			ostest.SkipIfBelowVersion(t, client, 1, 3, "ClusterManager")
+			ostest.SkipIfBelowOrEqualVersion(t, client, 1, 3, "ClusterManager")
 			resp, err := client.Cat.ClusterManager(nil, nil)
 			assert.Nil(t, err)
 			assert.NotNil(t, resp)

diff --git a/opensearchapi/api_cluster_test.go b/opensearchapi/api_cluster_test.go
@@ -230,7 +230,7 @@ func TestClusterClient(t *testing.T) {
 	for catType, value := range testCases {
 		t.Run(catType, func(t *testing.T) {
 			if strings.Contains(catType, "Decommission") {
-				ostest.SkipIfBelowVersion(t, client, 2, 3, catType)
+				ostest.SkipIfBelowOrEqualVersion(t, client, 2, 3, catType)
 			}
 			for _, testCase := range value {
 				t.Run(testCase.Name, func(t *testing.T) {

diff --git a/opensearchapi/api_point_in_time_test.go b/opensearchapi/api_point_in_time_test.go
@@ -23,7 +23,7 @@ import (
 func TestPointInTimeClient(t *testing.T) {
 	client, err := ostest.NewClient()
 	require.Nil(t, err)
-	ostest.SkipIfBelowVersion(t, client, 2, 4, "Point_In_Time")
+	ostest.SkipIfBelowOrEqualVersion(t, client, 2, 4, "Point_In_Time")
 	failingClient, err := osapitest.CreateFailingClient()
 	require.Nil(t, err)
 

diff --git a/opensearchapi/api_script_test.go b/opensearchapi/api_script_test.go
@@ -155,7 +155,7 @@ func TestScriptClient(t *testing.T) {
 	for _, value := range testCases {
 		t.Run(value.Name, func(t *testing.T) {
 			if strings.Contains(value.Name, "Language") {
-				ostest.SkipIfBelowVersion(t, client, 2, 3, value.Name)
+				ostest.SkipIfBelowOrEqualVersion(t, client, 2, 3, value.Name)
 			}
 			for _, testCase := range value.Tests {
 				t.Run(testCase.Name, func(t *testing.T) {
@@ -206,7 +206,7 @@ func TestScriptClient(t *testing.T) {
 			ostest.CompareRawJSONwithParsedJSON(t, resp, resp.Inspect().Response)
 		})
 		t.Run("Language", func(t *testing.T) {
-			ostest.SkipIfBelowVersion(t, client, 2, 3, "Language")
+			ostest.SkipIfBelowOrEqualVersion(t, client, 2, 3, "Language")
 			resp, err := client.Script.Language(nil, nil)
 			require.Nil(t, err)
 			assert.NotNil(t, resp)

diff --git a/plugins/ism/api_test.go b/plugins/ism/api_test.go
@@ -243,14 +243,14 @@ func TestClient(t *testing.T) {
 			ostest.CompareRawJSONwithParsedJSON(t, &resp, resp.Inspect().Response)
 		})
 		t.Run("Explain with validate_action", func(t *testing.T) {
-			ostest.SkipIfBelowVersion(t, osClient, 2, 3, "Explain with validate_action")
+			ostest.SkipIfBelowOrEqualVersion(t, osClient, 2, 3, "Explain with validate_action")
 			resp, err := client.Explain(nil, &ism.ExplainReq{Indices: testIndex, Params: ism.ExplainParams{ShowPolicy: true, ValidateAction: true}})
 			assert.Nil(t, err)
 			assert.NotNil(t, resp)
 			ostest.CompareRawJSONwithParsedJSON(t, &resp, resp.Inspect().Response)
 		})
 		t.Run("Explain with show_policy", func(t *testing.T) {
-			ostest.SkipIfBelowVersion(t, osClient, 1, 2, "Explain with validate_action")
+			ostest.SkipIfBelowOrEqualVersion(t, osClient, 1, 2, "Explain with validate_action")
 			resp, err := client.Explain(nil, &ism.ExplainReq{Indices: testIndex, Params: ism.ExplainParams{ShowPolicy: true}})
 			assert.Nil(t, err)
 			assert.NotNil(t, resp)

diff --git a/plugins/security/api_ssl_test.go b/plugins/security/api_ssl_test.go
@@ -30,7 +30,7 @@ func TestSSLClient(t *testing.T) {
 	osAPIclient, err := ostest.NewClient()
 	require.Nil(t, err)
 
-	ostest.SkipIfBelowVersion(t, osAPIclient, 1, 3, "SSLClient")
+	ostest.SkipIfBelowOrEqualVersion(t, osAPIclient, 1, 3, "SSLClient")
 
 	clientTLSCert, err := tls.LoadX509KeyPair("../../admin.pem", "../../admin.key")
 	require.Nil(t, err)
@@ -114,7 +114,7 @@ func TestSSLClient(t *testing.T) {
 			for _, testCase := range value.Tests {
 				t.Run(testCase.Name, func(t *testing.T) {
 					if strings.HasSuffix(value.Name, "Reload") && strings.Contains(testCase.Name, "request") {
-						ostest.SkipIfBelowVersion(t, osAPIclient, 2, 7, value.Name)
+						ostest.SkipIfBelowOrEqualVersion(t, osAPIclient, 2, 7, value.Name)
 					}
 					res, err := testCase.Results()
 					if testCase.Name == "inspect" {