Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver/pro#3407 Fix AbstractJdbcResultSet.getBigDecimal(int) to handle empty strings #52

Merged
merged 3 commits into from
Nov 6, 2024
Merged

dbeaver/pro#3407 Fix AbstractJdbcResultSet.getBigDecimal(int) to handle empty strings #52

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c2389e
dbeaver/pro#3407 Fix AbstractJdbcResultSet.getBigDecimal(int) to hand…
Oct 31, 2024
8d58b95
dbeaver/pro#3407 Cover FF CSV Driver by tests
Nov 1, 2024
d6c6534
Merge branch 'devel' into dbeaver/pro#3407-cover-csv-driver-with-tests
kseniaguzeeva Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion modules/com.dbeaver.jdbc.api/src/com/dbeaver/jdbc/model/AbstractJdbcResultSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,10 +616,14 @@
throw new SQLFeatureNotSupportedException();
}

@Override

Check warning on line 619 in modules/com.dbeaver.jdbc.api/src/com/dbeaver/jdbc/model/AbstractJdbcResultSet.java

View workflow job for this annotation

GitHub Actions / Check / Lint 

[checkstyle] reported by reviewdog 🐶
All overloaded methods should be placed next to each other. Previous overloaded method located at line '258'.

Raw Output:
/github/workspace/./modules/com.dbeaver.jdbc.api/src/com/dbeaver/jdbc/model/AbstractJdbcResultSet.java:619:5: warning: All overloaded methods should be placed next to each other. Previous overloaded method located at line '258'. (com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck)
public BigDecimal getBigDecimal(int columnIndex) throws SQLException {
final String value = getString(columnIndex);
return value != null ? new BigDecimal(value) : null;
if (value == null || value.isBlank()) {
return null;
}

return new BigDecimal(value);
}

@Override
Expand Down