CB-6063 feat: add ability to import data without PK #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnaumov
reviewed
Jan 10, 2025
| @@ -103,7 +103,7 @@ export class DataImportBootstrap extends Bootstrap { | |||
| const presentation = context.get(DATA_CONTEXT_DV_PRESENTATION); | |||
| const isContainer = model.source instanceof ContainerDataSource; | |||
| return ( | |||
| !model.isReadonly(resultIndex) && | |||
There was a problem hiding this comment.
Fix is not clear for me. Why do we need this? Previous logic seems fine
There was a problem hiding this comment.
this isReadonly method uses hasRowIdentifier inside, which we should ignore. How do you see this c check here?
There was a problem hiding this comment.
We probably want to add new flag something like isAppendAllowed as adding new row from ui is not allowed but import is allowed that basically does the same
removes isImportAllowed flag, adds hasRowIdentifier, uses it in place of forbidden actions
|
So we discussed with @Wroud and agreed that the only option to add the hasRowIdentifier flag because it is used in different places, not only related to insertion. This is how it works now: |
Wroud
requested changes
Jan 10, 2025
...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuCellEditingService.ts
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-data-viewer/src/DatabaseDataModel/DatabaseDataSource.ts
Outdated
Show resolved
Hide resolved
Wroud
approved these changes
Jan 13, 2025
sergeyteleshev
deleted the
CB-6063-Add-ability-to-import-data-in-table-without-PK
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-01-10.at.18.08.03-1.mov