CB-5369. Added API for transaction log for commits #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
requested changes
Jan 9, 2025
server/bundles/io.cloudbeaver.server/schema/service.core.graphqls
Outdated
Show resolved
Hide resolved
server/bundles/io.cloudbeaver.server/schema/service.core.graphqls
Outdated
Show resolved
Hide resolved
…its' into CB-5369-transaction-log-for-commits
…nsaction-log-for-commits' of https://github.com/dbeaver/cloudbeaver into CB-5369-transaction-log-for-commits
Wroud
requested changes
Jan 10, 2025
Comment on lines
45
to
46
| this.promise = payload.transaction.getLogs(); | ||
| const logs = await this.promise; |
There was a problem hiding this comment.
Promise is used by useAutoLoad with suspense. Current implementation may not work in some cases (because there is a chance that load will be called every re-render because of losing the state and will return a new promise every time)
...pp/packages/plugin-datasource-transaction-manager/src/TransactionLogs/useTransactionLogs.tsx
Outdated
Show resolved
Hide resolved
...pp/packages/plugin-datasource-transaction-manager/src/TransactionLogs/useTransactionLogs.tsx
Outdated
Show resolved
Hide resolved
...pp/packages/plugin-datasource-transaction-manager/src/TransactionLogs/useTransactionLogs.tsx
Outdated
Show resolved
Hide resolved
serge-rider
previously requested changes
Jan 12, 2025
server/bundles/io.cloudbeaver.server/schema/service.core.graphqls
Outdated
Show resolved
Hide resolved
server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/service/sql/WebSQLProcessor.java
Outdated
Show resolved
Hide resolved
server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/model/WebTransactionLogInfo.java
Outdated
Show resolved
Hide resolved
server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/service/sql/DBWServiceSQL.java
Outdated
Show resolved
Hide resolved
Wroud
reviewed
Jan 13, 2025
server/bundles/io.cloudbeaver.server/schema/service.events.graphqls
Outdated
Show resolved
Hide resolved
...packages/plugin-datasource-transaction-manager/src/TransactionLogs/TransactionLogsDialog.tsx
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-datasource-transaction-manager/src/TransactionManagerBootstrap.ts
Show resolved
Hide resolved
webapp/packages/plugin-datasource-transaction-manager/src/TransactionManagerBootstrap.ts
Outdated
Show resolved
Hide resolved
…its' into CB-5369-transaction-log-for-commits
Wroud
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.