-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-6051 ability to download drivers #3155
Merged
alexander-skoblikov
merged 30 commits into
devel
from
CB-6051-ability-to-download-driver-from-the-maven-repository
Jan 14, 2025
Merged
Changes from 8 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
3626613
CB-6051 wip
yagudin10 ea11343
CB-6051 refresh drivers after loading server config
yagudin10 fed0445
Merge remote-tracking branch 'origin/devel' into CB-6051-ability-to-d…
yagudin10 e297174
CB-6051 api for lib file info
yagudin10 85baf9c
CB-6071 show installed status
devnaumov b6c9d9e
Merge branch 'CB-6051-ability-to-download-driver-from-the-maven-repos…
devnaumov f16a950
Merge branch 'devel' into CB-6051-ability-to-download-driver-from-the…
devnaumov 847838e
Merge remote-tracking branch 'origin/devel' into CB-6051-ability-to-d…
yagudin10 2d4d151
CB-6051 make icon larger
devnaumov 8f78a09
Merge branch 'CB-6051-ability-to-download-driver-from-the-maven-repos…
devnaumov 690d71d
CB-6051 move out applicable drivers from platform class
yagudin10 343c5b4
Merge branch 'devel' into CB-6051-ability-to-download-driver-from-the…
EvgeniaBzzz 861a29b
CB-6051 fix detect external dependencies for te
yagudin10 1cda706
CB-6051 add driver status to the connection form
devnaumov de61206
Merge branch 'CB-6051-ability-to-download-driver-from-the-maven-repos…
devnaumov c89b9a7
CB-6051 fix error if driver is not found
yagudin10 5a2432b
Merge branch 'devel' into CB-6051-ability-to-download-driver-from-the…
yagudin10 0415053
CB-6051 add comments
yagudin10 b3c36c9
Merge branch 'devel' into CB-6051-ability-to-download-driver-from-the…
dariamarutkina 3c98139
CB-6051 add param that checks when libs can be downloaded
yagudin10 5dbc8fb
CB-6051 add downloadable flag
devnaumov ad8d6a4
Merge branch 'devel' into CB-6051-ability-to-download-driver-from-the…
devnaumov a7c4a59
CB-6051 check admin permission before showing status
devnaumov 493cd7d
CB-6051 remove uninstalled drivers from list for non-admin users
devnaumov 9e1107b
CB-6051 add logic to options
devnaumov 1757d43
Merge branch 'devel' into CB-6051-ability-to-download-driver-from-the…
dariamarutkina 4b82cb3
CB-6051 do not reset custom driver and fix message
yagudin10 ddf6b9e
CB-6051 add buttonText prop
devnaumov 7d9629b
Merge branch 'devel' into CB-6051-ability-to-download-driver-from-the…
dariamarutkina 9ec0172
Merge branch 'devel' into CB-6051-ability-to-download-driver-from-the…
dariamarutkina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/model/WebDriverLibraryFileInfo.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* DBeaver - Universal Database Manager | ||
* Copyright (C) 2010-2024 DBeaver Corp and others | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package io.cloudbeaver.model; | ||
|
||
import io.cloudbeaver.WebServiceUtils; | ||
import org.jkiss.code.NotNull; | ||
import org.jkiss.dbeaver.model.DBIcon; | ||
import org.jkiss.dbeaver.model.connection.DBPDriverLibrary; | ||
import org.jkiss.dbeaver.model.meta.Property; | ||
import org.jkiss.dbeaver.registry.driver.DriverDescriptor; | ||
|
||
public class WebDriverLibraryFileInfo { | ||
|
||
@NotNull | ||
private final DriverDescriptor.DriverFileInfo fileInfo; | ||
|
||
public WebDriverLibraryFileInfo(@NotNull DriverDescriptor.DriverFileInfo fileInfo) { | ||
this.fileInfo = fileInfo; | ||
} | ||
|
||
|
||
@Property | ||
public String getId() { | ||
return fileInfo.getId(); | ||
} | ||
|
||
@Property | ||
public String getFileName() { | ||
return fileInfo.toString(); | ||
} | ||
|
||
@Property | ||
public String getIcon() { | ||
if (fileInfo.getType() == DBPDriverLibrary.FileType.license) { | ||
return WebServiceUtils.makeIconId(DBIcon.TYPE_TEXT); | ||
} | ||
return WebServiceUtils.makeIconId(DBIcon.JAR); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be we need a bit more larger icon? this one seems too small for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, If we expect users to hover over that icon, it's better to have it at least 14px or 16px. WCAG recommends minimum 24px, however in our case it's not a button and maybe not so critical, so we can make it smaller.
And I personally would place it on top. For users it will make more sense in terms of catching their attention since such approach is commonly used among many applications for different type of notifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I have a better Idea. Why don't we just make the whole driver icon hoverable? I assume this is how it should work. Icon itself doesn't need to be a target