CB-3753-1809-fr-add-field-hints-in-the-filter-field #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
requested review from
Wroud,
devnaumov and
SychevAndrey
and removed request for
Wroud and
devnaumov
SychevAndrey
approved these changes
Dec 26, 2024
webapp/packages/core-blocks/src/FormControls/useInputAutocomplete.ts
Outdated
Show resolved
Hide resolved
webapp/packages/core-blocks/src/FormControls/useInputAutocomplete.ts
Outdated
Show resolved
Hide resolved
webapp/packages/core-blocks/src/FormControls/useInputAutocomplete.ts
Outdated
Show resolved
Hide resolved
devnaumov
requested changes
Dec 27, 2024
webapp/packages/core-blocks/src/FormControls/InputAutocompletionMenu.tsx
Show resolved
Hide resolved
This reverts commit 92e6714.
…AutocompleteMenu use this context
Wroud
requested changes
Jan 22, 2025
| } | ||
|
|
||
| export interface InputAutocompleteProposal { | ||
| id: string; |
There was a problem hiding this comment.
i suggest to remove this 'id' fields because:
- it's not in use
- it's just a "always" random string
|
please take a look at this: https://github.com/lucaong/react-minisearch |
Wroud
requested changes
Jan 24, 2025
webapp/packages/core-blocks/src/FormControls/InputAutocompletionMenu.tsx
Outdated
Show resolved
Hide resolved
webapp/packages/core-blocks/src/FormControls/useInputAutocomplete.ts
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-data-viewer/src/TableViewer/TableHeader/useTableViewerHeaderData.ts
Outdated
Show resolved
Hide resolved
Wroud
approved these changes
Jan 27, 2025
Comment on lines
39
to
42
| const contextMenuPosition = getComputed(() => ({ | ||
| position, | ||
| handleContextMenuOpen: () => {}, | ||
| })); |
There was a problem hiding this comment.
getComputed will not help cuz function always returns new object (getComputed works if you can return stable value, for example for primitives)
webapp/packages/core-blocks/src/FormControls/useInputAutocomplete.ts
Outdated
Show resolved
Hide resolved
devnaumov
approved these changes
Jan 27, 2025
devnaumov
deleted the
CB-3753-1809-fr-add-field-hints-in-the-filter-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.