Cb 5448 sql assist doesnt work after alias with enabled use long object names #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnaumov
requested changes
Dec 25, 2024
| @@ -80,7 +80,7 @@ export function useSqlDialectAutocompletion(data: ISQLEditorData): [Compartment, | |||
| const limitIsMet = optionsRef.data.hintsLimitIsMet; | |||
|
|
|||
| const result: CompletionResult = { | |||
| from: word.from, | |||
| from: getFrom(proposals, word.from), | |||
There was a problem hiding this comment.
We should use built in codemirror tools to apply proposal the way we want. It could be done by passing custom function
https://codemirror.net/docs/ref/#autocomplete.Completion.apply
…with-enabled-use-long-object-names
devnaumov
approved these changes
Dec 25, 2024
…with-enabled-use-long-object-names
devnaumov
deleted the
CB-5448-sql-assist-doesnt-work-after-alias-with-enabled-use-long-object-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.