Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-5503 Login form - incorrect password is cleared from the form after pressing Enter #2853

Merged
merged 11 commits into from
Aug 26, 2024
Merged

CB-5503 Login form - incorrect password is cleared from the form after pressing Enter #2853

merged 11 commits into from
Aug 26, 2024

Conversation

sergeyteleshev
Copy link
Contributor

No description provided.

@sergeyteleshev sergeyteleshev self-assigned this Aug 19, 2024
@Wroud
Copy link
Member

Wroud commented Aug 20, 2024

i suggest to revert this.ref?.reset(); calls from useForm hook and check other ways to solve problem with validation highlighting
form's 'reset' have different purpose and we can't use it to cover only validation case

sergeyteleshev and others added 9 commits August 20, 2024 19:27
@sergeyteleshev
CB-5431 redirect to item if page is not exists
d72118c
@sergeyteleshev
Revert "feat: Add form submission handling to AuthDialog"
2ecdaf8 
This reverts commit de19e67.
@sergeyteleshev
Revert "CB-5503 fix: Prevent form submission from erasing password in…
a7d4cb1 
…put value"

This reverts commit a5a74ae.
@sergeyteleshev
Merge branch 'devel' into CB-5503-login-form-incorrect-password-is-cl…
2fb9946 
…eared-from-the-form-after-pressing-enter
@sergeyteleshev
CB-5503 adds useValidationStyles for the form inputs
7702fdc
@sergeyteleshev
Revert "CB-5503 adds useValidationStyles for the form inputs"
955fa0e 
This reverts commit 7702fdc.
@sergeyteleshev
CB-5503 removes resets for useForm submit event
abe98a4
@Wroud
Merge remote-tracking branch 'origin/devel' into CB-5503-login-form-i…
6401a42 
…ncorrect-password-is-cleared-from-the-form-after-pressing-enter
@Wroud
fix: form submitting process
1c30c95
@serge-rider serge-rider merged commit 74aa8c7 into devel Aug 26, 2024
7 checks passed
@serge-rider serge-rider deleted the CB-5503-login-form-incorrect-password-is-cleared-from-the-form-after-pressing-enter branch August 29, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wroud Wroud Wroud approved these changes

@devnaumov devnaumov Awaiting requested review from devnaumov

Assignees

@sergeyteleshev sergeyteleshev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergeyteleshev @Wroud @serge-rider