Fix referencing isSilent under strict mode #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes db-migrate/node-db-migrate#590
This PR fixes a bug where when running db-migrate under strict mode (such as via its programmable api in a TS script), you'd get an undefined error when trying to reference
this.isSilent
. This is because under script mode, thethis
object is made undefined in a function as opposed to referencing the global scope (see "No this substitution" section in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode#changes_in_strict_mode). Instead, we make theisSilent
variable accessible on theexports
object which gives the same overall characteristics as the globalthis
(such as being accessible and changeable via require), but thatexports.isSilent
can be safely referenced within the functions.An alternative approach could be:
but this seemed more complicated than using
exports.isSilent
.