"ssl" config value should be boolean #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first time using this library, so disregard if I'm totally off-base here, but I kept running into issues locally on the latest version of this library, with a "The server does not support SSL connections" error message, despite having `"ssl": "false"` in this config file. From what I can gather, this should be a boolean value instead of a string, as the underlying `pg` lib depends on that. I found this recent PR which led me to thta conclusion: - https://github.com/brianc/node-postgres/pull/2394/files#diff-cc6abc00177b0fba133f7ea7b2fbe025fc21e789f243cfd85f9be7e0325f0bc2R83-R89 - https://github.com/brianc/node-postgres/pull/2394/files#diff-cc6abc00177b0fba133f7ea7b2fbe025fc21e789f243cfd85f9be7e0325f0bc2R61-R63 #### Changes included: - Use boolean for "ssl" config values in documentation **Before:** using `"ssl": "false"` in config caused "The server does not support SSL connections" fatal error **After:** everything works as expected with `"ssl": false` config value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time using this library, so disregard if I'm totally off-base here, but I kept running into issues locally on the latest version (
[email protected],[email protected],[email protected]), with an error:despite having
"ssl": "false"in this config file.From what I can gather, this should be a boolean value instead of a string, as the underlying
pglib depends on that. I found this recent PR which led me to that conclusion:Changes included:
Before: using
"ssl": "false"in config caused "The server does not support SSL connections" fatal errorAfter: everything works as expected with
"ssl": falseconfig value