More nits

davxy · May 30, 2024 · c4d99a5 · c4d99a5
1 parent bcdcd0f
commit c4d99a5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -50,6 +50,7 @@ pub type CurveConfig<S> = <AffinePoint<S> as AffineRepr>::Config;
 pub type HashOutput<S> = digest::Output<<S as Suite>::Hasher>;
 
 /// Verification error(s)
+#[derive(Debug)]
 pub enum Error {
     VerificationFailure,
 }

diff --git a/src/ring.rs b/src/ring.rs
@@ -164,12 +164,12 @@ where
         self.piop_params.keyset_part_size
     }
 
-    pub fn prover_key(&self, pks: Vec<AffinePoint<S>>) -> ProverKey<S> {
+    pub fn prover_key(&self, pks: &[AffinePoint<S>]) -> ProverKey<S> {
         let pks = pks.iter().map(|p| p.into_sw()).collect();
         ring_proof::index(self.pcs_params.clone(), &self.piop_params, pks).0
     }
 
-    pub fn verifier_key(&self, pks: Vec<AffinePoint<S>>) -> VerifierKey<S> {
+    pub fn verifier_key(&self, pks: &[AffinePoint<S>]) -> VerifierKey<S> {
         let pks: Vec<_> = pks.iter().map(|p| p.into_sw()).collect();
         ring_proof::index(self.pcs_params.clone(), &self.piop_params, pks).1
     }

diff --git a/src/testing.rs b/src/testing.rs
@@ -90,14 +90,11 @@ where
     let mut pks = random_vec::<AffinePoint<S>>(keyset_size, Some(rng));
     pks[prover_idx] = public.0;
 
-    let prover_key = ring_ctx.prover_key(pks.clone());
+    let prover_key = ring_ctx.prover_key(&pks);
     let prover = ring_ctx.prover(prover_key, prover_idx);
     let proof = secret.prove(input, output, b"foo", &prover);
-    let mut buf = Vec::new();
-    proof.serialize_compressed(&mut buf).unwrap();
-    println!("RING PROOF LEN: {}", buf.len());
 
-    let verifier_key = ring_ctx.verifier_key(pks);
+    let verifier_key = ring_ctx.verifier_key(&pks);
     let verifier = ring_ctx.verifier(verifier_key);
     let result = Public::verify(input, output, b"foo", &proof, &verifier);
     assert!(result.is_ok());