Work done primarily in build_rates (and related tests)

[rynkwn]

• Updated rates.RData up to Sept. 16, 2016
• Made several fixes to build_rates.
  • Removed a nil variable that was never assigned.
  • Adjusted one of the if statements that relied on the nil variable.
• Added a test for build_rates to ensure that vectors aren't passed in for inputs. (Causes R session to crash).
• Adjusted some tests: No longer uses stopifnot(statement), now uses expect_true(statement)

[sovboss]

Getting the following calling build_rates or download_markit:
Error in UseMethod("xmlSApply") :
no applicable method for 'xmlSApply' applied to an object of class "character"

[sovboss]

It looks like the problem is in get_raw_markit() function. The call is getting timed out if internal network requires proxy settings for the curlPerform to connect directly to www.markit.com. If I do the below proxy setting before the curlPerform the request goes through.

Could you add the variable to the creditr package functions for the user to be able to specify proxy settings and test if that does the trick?

curl <- getCurlHandle()
curlSetOpt(.opts = list(proxy = "

:"), curl = curl)

a <- tryCatch(curlPerform(url = 'https://www.markit.com/news/InterestRates_USD_20180515.zip',
writedata = f@ref,
noprogress = TRUE,
verbose = FALSE,
ssl.verifypeer = FALSE,
curl = curl),
error = function(e){ return("Rates data not available at markit.com") })

[rynkwn]

Hey @sovboss, sorry, but it's been a long time since I worked with this code base. I'm not sure who's primarily working on the code base at this time, but it may be worth leaving an issue on this project (https://github.com/davidkane9/creditr/projects/1) if you can! (I'm not sure where the Issues section has gone for this Github repo.)