Skip to content

Commit

Permalink
buildtools/chkincs: check driver specific headers
Browse files Browse the repository at this point in the history
Only driver headers exported by libraries were checked.
Add driver specific headers to the checked headers list.

This reveals a small issue with the vmbus driver header as some driver
headers rely on it.

Fixes: b232b2a ("buildtools/chkincs: check SDK headers for C++ compatibility")
Fixes: 84aaf06 ("bus/vmbus: make driver-only headers private")

Signed-off-by: David Marchand <david.marchand@redhat.com>
  • Loading branch information
david-marchand committed Oct 21, 2024
1 parent 8e3273c commit d6fe101
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions buildtools/chkincs/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ sources += gen_c_files.process(dpdk_chkinc_headers)
# some driver SDK headers depend on these two buses, which are mandatory in build
# so we always include them in deps list
deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')]
if dpdk_conf.has('RTE_BUS_VMBUS')
deps += get_variable('shared_rte_bus_vmbus')
endif
# add the rest of the libs to the dependencies
foreach l:dpdk_libs_enabled
deps += get_variable('shared_rte_' + l)
Expand Down
1 change: 1 addition & 0 deletions drivers/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ foreach subpath:subdirs
if get_option('enable_driver_sdk')
install_headers(driver_sdk_headers)
endif
dpdk_chkinc_headers += driver_sdk_headers

if headers.length() > 0
dpdk_includes += include_directories(drv_path)
Expand Down

0 comments on commit d6fe101

Please sign in to comment.